Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport v2.10.0] Replace v-tooltip with v-clean-tooltip #12569

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 8, 2024

This is an automated request to port PR #12565 by @rak-phillip

Original PR body:

Summary

This replaces v-tooltip with v-clean-tooltip. It appears that some new features written since the introduction of v-clean-tooltip haven't been using the new directive.

This also fixes the v-clean-tooltip directive in Vue3. The API for directives has changed in Vue3:

  • bind is now beforeMount
  • update has been removed and updated is recommended

Fixes #12566

Occurred changes and/or fixed issues

  • replace v-tooltip with v-clean-tooltip
  • update v-clean-tooltip to use Vue3 compatible API

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@github-actions github-actions bot added this to the v2.10.0 milestone Nov 8, 2024
@rak-phillip rak-phillip linked an issue Nov 8, 2024 that may be closed by this pull request
The interface for custom directives has changed in some important ways in Vue3.

- `bind` is now `beforeMount`
- `update` has been removed and `updated` is recommended

Signed-off-by: Phillip Rak <[email protected]>
@rak-phillip rak-phillip merged commit 76c7e7e into release-2.10 Nov 11, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[backport v2.10.0] Replace v-tooltip usage
2 participants